• Joined on 2025-12-07
Koko210 closed issue Koko210/miku-discord#4 2026-02-18 12:10:02 +02:00
HIGH: Voice Session Leaks - Unclosed Discord Audio Connections
Koko210 commented on issue Koko210/miku-discord#4 2026-02-18 12:09:39 +02:00
HIGH: Voice Session Leaks - Unclosed Discord Audio Connections

Addressed in commit 8d51370 as part of the graceful shutdown implementation. The new graceful_shutdown() function explicitly calls VoiceSessionManager.end_session() as its first step, which…

Koko210 commented on issue Koko210/miku-discord#5 2026-02-18 12:08:54 +02:00
HIGH: No Graceful Shutdown on Bot Exit

Fixed in commit 8d51370. Implemented a comprehensive async graceful_shutdown() function that replaces the old sync-only handler. The shutdown sequence now: (1) ends active voice sessions, (2)…

Koko210 pushed to master at Koko210/miku-discord 2026-02-18 12:08:42 +02:00
8d5137046c fix(shutdown): implement graceful async shutdown handler
Koko210 closed issue Koko210/miku-discord#5 2026-02-18 12:08:42 +02:00
HIGH: No Graceful Shutdown on Bot Exit
Koko210 commented on issue Koko210/miku-discord#1 2026-02-18 12:02:33 +02:00
CRITICAL: Unhandled Asyncio Tasks (Fire-and-Forget Pattern)

Fixed in commit 7b7abcf. Added utils/task_tracker.py with a create_tracked_task() wrapper that logs errors with full tracebacks, handles cancellation, and keeps strong references to prevent GC.…

Koko210 pushed to master at Koko210/miku-discord 2026-02-18 12:01:52 +02:00
7b7abcfc68 fix(tasks): replace fire-and-forget asyncio.create_task with create_tracked_task
Koko210 closed issue Koko210/miku-discord#1 2026-02-18 12:01:52 +02:00
CRITICAL: Unhandled Asyncio Tasks (Fire-and-Forget Pattern)
Koko210 closed issue Koko210/miku-discord#28 2026-02-16 23:35:47 +02:00
HIGH: Add Circuit Breakers for Critical Services
Koko210 commented on issue Koko210/miku-discord#28 2026-02-16 23:35:41 +02:00
HIGH: Add Circuit Breakers for Critical Services

Closing as Already Implemented - A circuit breaker already exists for the Cheshire Cat service in bot/utils/cat_client.py lines 45-100. The CatAdapter class has full circuit breaker functionality:…

Koko210 closed issue Koko210/miku-discord#12 2026-02-16 23:35:22 +02:00
LOW: SQL Injection Risk in Memory Queries
Koko210 commented on issue Koko210/miku-discord#12 2026-02-16 23:34:55 +02:00
LOW: SQL Injection Risk in Memory Queries

Closing as Invalid - The project does not use SQL or a SQL database. The Cheshire Cat memory system uses Qdrant, which is a vector database accessed through its Python SDK, not raw SQL queries.…

Koko210 closed issue Koko210/miku-discord#8 2026-02-16 23:34:40 +02:00
MEDIUM: Hardcoded URLs and Configuration Values
Koko210 commented on issue Koko210/miku-discord#8 2026-02-16 23:34:31 +02:00
MEDIUM: Hardcoded URLs and Configuration Values

Closing as Invalid - All URLs are already environment-configurable, not hardcoded. In bot/globals.py lines 25-26 and 36, all URLs use os.getenv() with Docker service name defaults: LLAMA_URL,…

Koko210 closed issue Koko210/miku-discord#3 2026-02-16 23:34:04 +02:00
CRITICAL: File Operations Without Context Managers
Koko210 commented on issue Koko210/miku-discord#3 2026-02-16 23:33:32 +02:00
CRITICAL: File Operations Without Context Managers

Closing as Invalid

I've thoroughly reviewed the codebase and verified every file mentioned in this issue. All 7 files cited already use statement context managers for file operations:

  • :…
Koko210 opened issue Koko210/miku-discord#31 2026-02-16 22:55:35 +02:00
MEDIUM: Optimize Memory Usage
Koko210 opened issue Koko210/miku-discord#30 2026-02-16 22:53:49 +02:00
MEDIUM: Add Performance Logging
Koko210 opened issue Koko210/miku-discord#29 2026-02-16 22:52:01 +02:00
HIGH: Add Comprehensive Input Validation
Koko210 opened issue Koko210/miku-discord#28 2026-02-16 22:51:16 +02:00
HIGH: Add Circuit Breakers for Critical Services